Feature/334 report email confirmation form #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 15, 2022 09:08
…ranch for this feature
mjtravers
requested changes
Jul 20, 2022
front-end/src/app/reports/f3x/submission-workflow/submit-f3x-step1.component.ts
Outdated
Show resolved
Hide resolved
front-end/src/app/reports/f3x/submission-workflow/submit-f3x-step1.component.ts
Outdated
Show resolved
Hide resolved
front-end/src/app/reports/f3x/submission-workflow/submit-f3x-step1.component.ts
Outdated
Show resolved
Hide resolved
mjtravers
requested changes
Jul 21, 2022
There was a problem hiding this comment.
This is good. I like the way you remembered to dispatch to the store to refresh the committee account info and make sure the reportCodeList has data.
Only request is to expand the unit testing to get it over 80%:
Oh and one ANDI issue. The other issues are with the left nav and can be ignored but here is a label issue on the email input elements of the form:
|
SonarCloud Quality Gate failed. |
mjtravers
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334
Paired with this API branch
Re: Cloudsonar feedback:
The code smell is a block that was commented out on Mitchell's request. It contained a line that is probably unnecessary now that we are collecting the change of address at the end of the report instead of the beginning. Mitchell wants it preserved in a comment in case this proves incorrect.
The security vulnerability is the regex that provides simple checking for whether or not an email is valid. Supposedly it could be used in a Denial-of-service attack? A saved email could be difficult for the local validator in the browser to parse later.
I don't think the fear is relevant given the small maximum length allowed.