Defect/173 report coverage date overlap #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shelly has pointed out that a comment on the ticket adds fixing the coverage date fields to the requirements. A fix for that has been added. |
toddlees
previously requested changes
Aug 4, 2022
front-end/src/app/reports/f3x/create-workflow/create-f3x-step1.component.ts
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
mjtravers
approved these changes
Aug 4, 2022
mjtravers
dismissed
toddlees’s stale review
Issue was resolved. No timing is used now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Ticket 173
Updates the coverage date overlap checking to catch an edge case where a new report is created whose dates entirely encompass another report's dates. Adds unit tests to verify that the edge case has been caught.