Feature/379 view filing #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiated within an F3xSummary instance
…king on emails to prevent them from spilling out of the column
dheitzer
approved these changes
Aug 12, 2022
| const uploadStatus: FECUploadStatus = FECUploadStatus.fromJSON(data); | ||
| expect(uploadStatus).toBeInstanceOf(FECUploadStatus); | ||
| expect(uploadStatus.created).toBeInstanceOf(Date); | ||
| console.log(uploadStatus.created); |
There was a problem hiding this comment.
very minor - maybe remove this?
toddlees
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Looks great! I think there might be a requirements gap for when there's an error between clicking submit and our first request to FEC. Maybe we can make a ticket down the line to handle this scenario. Failure before the first request to FEC could be an issue compiling the .fec or a network issue when we try to submit to FEC, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#379