Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/355 read only reports #455

Merged
merged 32 commits into from
Aug 14, 2022
Merged

Feature/355 read only reports #455

merged 32 commits into from
Aug 14, 2022

Commits on Aug 10, 2022

  1. Starts on providing the guards necessary to block editing a submitted… 

    … report
    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    733c838 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Implements a working guard

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    4b99626 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/355-read-only-reports

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    99b7060 View commit details
    Browse the repository at this point in the history

  3. Begins utilizing the new guard. Guard is not behaving as expected

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    54dc5ce View commit details
    Browse the repository at this point in the history

  4. WIP

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    dec6709 View commit details
    Browse the repository at this point in the history

  5. More WIP

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c69c908 View commit details
    Browse the repository at this point in the history

  6. Fixes the layout so that it properly uses the ReportIsEditableService

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ec2b6f7 View commit details
    Browse the repository at this point in the history

  7. WIP...

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    68a76e3 View commit details
    Browse the repository at this point in the history

  8. Updates some console.logs for clarity

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    869e33a View commit details
    Browse the repository at this point in the history

  9. The guard and service finally work

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f818e96 View commit details
    Browse the repository at this point in the history

  10. Removes a console.log()

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    32235c7 View commit details
    Browse the repository at this point in the history

  11. Per ticket requirements, the report menu no longer shows the Enter A … 

    …Transaction section when the report is not editable.
    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    74d2bad View commit details
    Browse the repository at this point in the history

  12. Starts on unit tests

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    465a649 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'feature/379-view-filing-id' into feature/355-read-only-… 

    …reports
    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    95da7ff View commit details
    Browse the repository at this point in the history

  14. Restructuring

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7f1c9cc View commit details
    Browse the repository at this point in the history

  15. Removes unused imports

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0fc4b82 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Adds a unit test for the report-is-editable service

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    66dc5ae View commit details
    Browse the repository at this point in the history

  2. Removes an unused variable

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6def6f0 View commit details
    Browse the repository at this point in the history

  3. Removes an unused variable

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    45202bb View commit details
    Browse the repository at this point in the history

  4. Refreshes the active report after submitting it

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    bb83a82 View commit details
    Browse the repository at this point in the history

  5. WIP

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    c6feab8 View commit details
    Browse the repository at this point in the history

  6. Implements Todd's feedback and makes it so that the menu doesn't subs… 

    …cribe inside a subscription
    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    0caa1b2 View commit details
    Browse the repository at this point in the history

  7. Removes unused import

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    846ebfd View commit details
    Browse the repository at this point in the history

  8. Adds unit tests for the guard

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    fa1c29c View commit details
    Browse the repository at this point in the history

  9. Renames report-is-editable.guards -> .guard

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    a0c91db View commit details
    Browse the repository at this point in the history

  10. Renames import

    @Elaine-Krauss-TCG
    Elaine-Krauss-TCG committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    248a52d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. Resolved merge conflicts

    @mjtravers
    mjtravers committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    6f7d130 View commit details
    Browse the repository at this point in the history

  2. Added UploadSubmission to report interface

    @mjtravers
    mjtravers committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    e8ea85c View commit details
    Browse the repository at this point in the history

  3. Added set active report to guard and resolver

    @mjtravers
    mjtravers committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    595cc00 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Replaced ActivatedRoute to get report with call to ngrx store

    @mjtravers
    mjtravers committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    0f55e03 View commit details
    Browse the repository at this point in the history

  2. Fixed issues with COH saving to store and routing

    @mjtravers
    mjtravers committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    4eef8cd View commit details
    Browse the repository at this point in the history

  3. Updated unit tests

    @mjtravers
    mjtravers committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    1927875 View commit details
    Browse the repository at this point in the history