Feature/550 remove report creation step 2

[Elaine-Krauss-TCG]

#550

Removes Report Creation Step 2

[mjtravers]

Looks good. Can be merged to develop after the code change is made to flatten the nested subscriptions as noted by Todd

[Elaine-Krauss-TCG]

The switchmaps no longer have an unused variable, so that should no longer be an issue, @toddlees

[toddlees]

The switchmaps no longer have an unused variable, so that should no longer be an issue, @toddlees

👍 I see you hid it in the response array. if you want to drop the tabledata after the observable resolves you can map it to report like below, but it works that way too!

    createReport$.pipe(
      switchMap((report) =>  getTableData$.pipe(map(()=>report))),
      switchMap((report)=> zip(of(report), cashOnHand$)),
      takeUntil(this.destroy$)
    ).subscribe(([report, cashOnHand]) => {

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

84.2% Coverage
0.0% Duplication