Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/413 new cmtee contact from transaction #589

Merged
merged 20 commits into from
Sep 26, 2022

Conversation

dheitzer
Copy link
Contributor

This is the code review for app tickets 549, 243, 413

@dheitzer
Copy link
Contributor Author

Note that some of the large diffs are me moving the form portion of contact-details to shared component 'contact-form' to be used in both contact-detail and the 'new contact' dialog for lookup.

@dheitzer dheitzer marked this pull request as draft September 23, 2022 19:24
@dheitzer dheitzer marked this pull request as ready for review September 23, 2022 23:10
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.9% 86.9% Coverage
8.2% 8.2% Duplication

@mjtravers mjtravers merged commit 64a74f0 into develop Sep 26, 2022
@mjtravers mjtravers deleted the feature/413-new-cmtee-contact-from-transaction branch September 26, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants