Feature/237 aggregation groups #610
Conversation
… the individual transaction types
| @@ -255,3 +256,11 @@ export const ScheduleATransactionTypeLabels: LabelList = [ | |||
| 'Earmark Receipt for Headquarters Account (Contribution)', | |||
| ], | |||
| ]; | |||
|
|
|||
| export type AggregationGroup = | |||
There was a problem hiding this comment.
Do we want to make this an enum instead (similar to ScheduleATransactionGroups for example)?
| @@ -20,6 +20,7 @@ export class EARMARK_RECEIPT implements TransactionType { | |||
| return SchATransaction.fromJSON({ | |||
| form_type: 'SA11AI', | |||
| transaction_type_identifier: ScheduleATransactionTypes.EARMARK_RECEIPT, | |||
| aggregation_group: "General", | |||
There was a problem hiding this comment.
If we make AggregationGroup an enum, we can reference it directly here (and aggregation_group will be typed). Same comment applies for all the similar .fromJSON( calls in this diff.
There was a problem hiding this comment.
I agree with David, an enum has a bit more flexibility. Here it would be referenced by something like AggregationGroup.GENERAL rather than "General". That way if the internal ID ever changes or something of the sort then the enum is changed and the references in the code can stay as is. See what was done with the combination of enums and typing for F3XFormTypes and F3xFormType in f3x-summary.model.ts
| @@ -20,6 +20,7 @@ export class EARMARK_RECEIPT implements TransactionType { | |||
| return SchATransaction.fromJSON({ | |||
| form_type: 'SA11AI', | |||
| transaction_type_identifier: ScheduleATransactionTypes.EARMARK_RECEIPT, | |||
| aggregation_group: "General", | |||
There was a problem hiding this comment.
I agree with David, an enum has a bit more flexibility. Here it would be referenced by something like AggregationGroup.GENERAL rather than "General". That way if the internal ID ever changes or something of the sort then the enum is changed and the references in the code can stay as is. See what was done with the combination of enums and typing for F3XFormTypes and F3xFormType in f3x-summary.model.ts
|
SonarCloud Quality Gate failed. |
#237
Validator PR
API PR