Release/sprint 16

front-end/cypress/e2e/general/login.cy.ts

@@ -15,16 +15,6 @@ const errorEmail = '.error__email-id';
 const errorCommitteeID = '.error__committee-id';
 const errorPassword = '.error__password-error';
 
-//two-factor authentication page form-fields' ids
-const fieldTwoFactorEmail = '#email';
-const fieldTwoFactorPhoneText = '#phone_number_text';
-const fieldTwoFactorPhoneCall = '#phone_number_call';
-const fieldTwoFactorSubmit = '.action__btn.next';
-
-//security code page form-fields' ids
-const fieldSecurityCodeText = '.form-control';
-const fieldSecurityCodeNext = '.action__btn.next';
-
 /*
 
     Supporting Functions
@@ -39,19 +29,11 @@ function fillLoginForm() {
 }
 
 //Logs in without entering anything for Two Factor Authentication
-function loginNoTwoFactor() {
+function login() {
   fillLoginForm();
   cy.get(fieldPassword).safeType('{enter}');
 }
 
-//Logs in and requests Two Factor Authentication via Email
-function loginRequestTwoFactorAuth() {
-  loginNoTwoFactor();
-
-  cy.get(fieldTwoFactorEmail).check();
-  cy.get(fieldTwoFactorSubmit).click();
-}
-
 /*
 
     Cypress E2E Tests
@@ -75,71 +57,24 @@ describe('Testing login', () => {
     fillLoginForm();
 
     cy.get(fieldPassword).safeType('{enter}');
-    cy.url().should('contain', '/twoFactLogin');
+    cy.url().should('contain', '/dashboard');
   });
 
   it('Submits Email/committee ID/password with a click', () => {
     fillLoginForm();
 
     cy.get(fieldLoginButton).click();
-    cy.url().should('contain', '/twoFactLogin');
-  });
-
-  it('Submits Two Factor Auth via Email', () => {
-    loginNoTwoFactor();
-
-    cy.get(fieldTwoFactorEmail).check();
-    cy.get(fieldTwoFactorSubmit).click();
-    cy.url().should('contain', '/confirm-2f');
-  });
-
-  it('Submits Two Factor Auth via phone, text', () => {
-    loginNoTwoFactor();
-
-    cy.get(fieldTwoFactorPhoneText).check();
-    cy.get(fieldTwoFactorSubmit).click();
-    cy.url().should('contain', '/confirm-2f');
-  });
-
-  it('Submits Two Factor Auth via phone, call', () => {
-    loginNoTwoFactor();
-
-    cy.get(fieldTwoFactorPhoneCall).check();
-    cy.get(fieldTwoFactorSubmit).click();
-    cy.url().should('contain', '/confirm-2f');
-  });
-
-  it('Fully logs in through Two Factor Authentication with {enter}', () => {
-    loginRequestTwoFactorAuth();
-
-    cy.get(fieldSecurityCodeText).safeType(testPIN).safeType('{enter}');
     cy.url().should('contain', '/dashboard');
-    cy.logout();
-  });
-
-  it('Fully logs in through Two Factor Authentication with a click', () => {
-    loginRequestTwoFactorAuth();
-
-    cy.get(fieldSecurityCodeText).safeType(testPIN);
-    cy.get(fieldSecurityCodeNext).click();
-    cy.url().should('contain', '/dashboard');
-    cy.logout();
   });
 
   it('Logs in and checks for Committee Account Details', () => {
-    loginRequestTwoFactorAuth();
-
-    cy.get(fieldSecurityCodeText).safeType(testPIN);
-
-    cy.intercept(
-      "GET", "https://api.open.fec.gov/v1/committee/*/*"
-    ).as("GetCommitteeAccount");
+    cy.intercept('GET', 'https://api.open.fec.gov/v1/committee/*/*').as('GetCommitteeAccount');
 
-    cy.get(fieldSecurityCodeNext).click();
+    login();
 
-    cy.wait("@GetCommitteeAccount");
+    cy.wait('@GetCommitteeAccount');
     cy.url().should('contain', '/dashboard');
-    cy.get(".committee-banner").contains(committeeID).should("exist");
+    cy.get('.committee-banner').contains(committeeID).should('exist');
 
     cy.logout();
   });

front-end/cypress/e2e/reports/Reports-Submission-Walkthrough.cy.ts

@@ -1,5 +1,6 @@
 // @ts-check
 
+import { generateContactToFit } from '../../support/generators/contacts.spec';
 import {
   generateConfirmationDetails,
   generateFilingDetails,
@@ -9,6 +10,7 @@ import { generateTransactionObject } from '../../support/generators/transactions
 
 const report = generateReportObject();
 const transaction = generateTransactionObject();
+const contact = generateContactToFit(transaction);
 const confirmationDetails = generateConfirmationDetails();
 const filingDetails = generateFilingDetails();
 
@@ -17,6 +19,12 @@ describe('Test creating and submitting a report', () => {
     cy.login();
   });
 
+  after('', () => {
+    cy.login();
+    cy.visit('/dashboard');
+    cy.deleteAllReports();
+  });
+
   it('', () => {
     cy.visit('/dashboard');
     cy.get('.p-menubar').find('.p-menuitem-link').contains('Reports').click();
@@ -27,7 +35,7 @@ describe('Test creating and submitting a report', () => {
     cy.navigateToTransactionManagement();
 
     //Creates a transaction
-    cy.createTransactionSchA(transaction);
+    cy.createTransactionSchA(transaction, contact);
 
     //Checks pre-existing confirmation details
     cy.navigateReportSidebar('Submit', 'Confirm information');
@@ -86,7 +94,5 @@ describe('Test creating and submitting a report', () => {
       const date = `${months[d.getMonth()]} ${d.getDate()}, ${d.getFullYear()}`;
       cy.get('body').should('contain', date);
     }
-
-    cy.deleteAllReports();
   });
 });

front-end/cypress/e2e/reports/Reports-Web-Print.cy.ts

@@ -1,10 +1,12 @@
 // @ts-check
 
+import { generateContactToFit } from '../../support/generators/contacts.spec';
 import { generateReportObject } from '../../support/generators/reports.spec';
 import { generateTransactionObject } from '../../support/generators/transactions.spec';
 
 const report = generateReportObject();
 const transaction = generateTransactionObject();
+const contact = generateContactToFit(transaction);
 
 describe('Test creating a report and submitting it for web print', () => {
   before('Logs in and clears existing reports', () => {
@@ -24,7 +26,7 @@ describe('Test creating a report and submitting it for web print', () => {
     cy.navigateToTransactionManagement();
 
     //Creates a transaction
-    cy.createTransactionSchA(transaction);
+    cy.createTransactionSchA(transaction, contact);
 
     //Submits the report to web print
     cy.navigateReportSidebar('Review', 'View print preview');

front-end/cypress/e2e/sprint-10/sprint-10-test-125.cy.ts

@@ -1,3 +1,4 @@
+import { generateContactIndividual } from '../../support/generators/contacts.spec';
 import { generateReportObject } from '../../support/generators/reports.spec';
 import { generateTransactionObject } from '../../support/generators/transactions.spec';
 
@@ -48,12 +49,13 @@ describe('QA Script 125 (Sprint 10)', () => {
       cy.medWait();
       cy.navigateToTransactionManagement();
 
+      const contact = generateContactIndividual({});
       const transaction = generateTransactionObject({
         'INDIVIDUALS/PERSONS': {
           'Individual Receipt': {},
         },
       });
-      cy.createTransactionSchA(transaction);
+      cy.createTransactionSchA(transaction, contact);
       cy.medWait();
     }
 

front-end/cypress/e2e/sprint-10/sprint-10-test-347.cy.ts

@@ -1,3 +1,4 @@
+import { generateContactCommittee } from '../../support/generators/contacts.spec';
 import { generateReportObject } from '../../support/generators/reports.spec';
 import { generateTransactionObject } from '../../support/generators/transactions.spec';
 import { createTransactionSchA } from '../../support/transactions.spec';
@@ -7,36 +8,44 @@ describe('QA Script 347 (Sprint 10)', () => {
     cy.login();
     cy.visit('/dashboard');
     cy.deleteAllReports();
+    cy.deleteAllContacts();
+  });
+
+  before('', () => {
+    cy.login();
   });
 
   it('', () => {
     //Logs in and creates a dummy report
     cy.login();
     cy.visit('/dashboard');
+
     const report = generateReportObject();
     cy.createReport(report);
     cy.shortWait();
-    cy.get('p-button[icon="pi pi-pencil"]').click();
+    cy.get('p-button[icon="pi pi-pencil"]').click({ force: true });
     cy.navigateToTransactionManagement();
 
     //Tests the summary page for a report
+    const contactObject = generateContactCommittee({});
     const transactionTree = generateTransactionObject({
       TRANSFERS: {
         'Joint Fundraising Transfer': {},
       },
     });
-    createTransactionSchA(transactionTree);
+    createTransactionSchA(transactionTree, contactObject);
     cy.medWait();
     const parentTransaction = transactionTree['TRANSFERS']['Joint Fundraising Transfer'];
     const childTransaction = parentTransaction['childTransactions'][0];
-    const childName = childTransaction['contributorOrganizationName'];
+    const contribution = childTransaction['contributionAmount'] as number;
+    const convContribution = Intl.NumberFormat('en-US').format(Math.floor(contribution));
 
-    cy.contains('tr', parentTransaction['contributorOrganizationName'])
-      .find('>td')
+    cy.contains('tr', 'JOINT_FUNDRAISING_TRANSFER')
+      .find('td')
       .eq(6)
       .then(($td) => {
         const parentId = $td.text();
-        cy.contains('tr', childName).find('td').eq(7).should('have.text', parentId);
+        cy.contains('tr', convContribution).find('td').eq(7).should('have.text', parentId);
       });
   });
 });

front-end/cypress/e2e/sprint-13/sprint-13-test-439,445.cy.ts

@@ -1,5 +1,7 @@
 // @ts-check
 
+import { enterContact } from '../../support/contacts.spec';
+import { generateContactToFit } from '../../support/generators/contacts.spec';
 import { generateReportObject } from '../../support/generators/reports.spec';
 import { generateTransactionObject } from '../../support/generators/transactions.spec';
 import { createTransactionSchA } from '../../support/transactions.spec';
@@ -31,9 +33,19 @@ describe('QA Script 244 (Sprint 8)', () => {
 
     //Step 4: Create a Joint Fundraising Transfer MEMO transaction
     const transaction = generateTransactionObject({ TRANSFERS: { 'Joint Fundraising Transfer': {} } });
-    createTransactionSchA(transaction, false);
-    cy.get('button[label="Save & add a Memo"]').click();
+    const contact = generateContactToFit(transaction);
+    createTransactionSchA(transaction, contact, false);
+    cy.get('p-dropdown[formcontrolname="subTransaction"]').click();
+    cy.contains('li', 'PAC JF Transfer Memo').click();
+    cy.shortWait();
+    cy.get('.p-confirm-dialog-accept').click();
     cy.longWait();
+
+    cy.contains('a', 'Create a new contact').click();
+    cy.longWait();
+    enterContact(contact, true, true);
+    cy.medWait();
+
     cy.contains('The dollar amount in a memo item is not incorporated into the total figure for the schedule').should(
       'exist'
     );

front-end/cypress/e2e/sprint-14/sprint-14-test-243,549.cy.ts

@@ -0,0 +1,91 @@
+// @ts-check
+
+import * as _ from 'lodash';
+import {
+  generateContactCommittee,
+  generateContactIndividual,
+  generateContactOrganization,
+} from '../../support/generators/contacts.spec';
+import { generateReportObject } from '../../support/generators/reports.spec';
+import { generateTransactionObject } from '../../support/generators/transactions.spec';
+
+//Contacts
+const contactIndividual = generateContactIndividual({});
+const contactOrganization = generateContactOrganization({});
+const contactCommittee = generateContactCommittee({});
+
+//Individual Transactions
+const indvRecTree = {
+  'INDIVIDUALS/PERSONS': {
+    'Individual Receipt': {
+      contributionDate: new Date('12/12/2012'),
+      contributionAmount: _.random(10, 500, false),
+    },
+  },
+};
+const tTreeIndividualA = generateTransactionObject(indvRecTree);
+
+//Organization Transactions
+const orgRecTree = {
+  'INDIVIDUALS/PERSONS': {
+    'Tribal Receipt': {
+      contributionDate: new Date('12/12/2012'),
+      contributionAmount: _.random(10, 500, false),
+    },
+  },
+};
+const tTreeOrganizationA = generateTransactionObject(orgRecTree);
+
+//JF Transfer Transfers
+const JFTransTree = {
+  TRANSFERS: {
+    'Joint Fundraising Transfer': {
+      contributionDate: new Date('12/12/2012'),
+      contributionAmount: _.random(10, 250, false),
+    },
+  },
+};
+const tTreeJFTransA = generateTransactionObject(JFTransTree);
+
+describe('QA Script 244 (Sprint 8)', () => {
+  after(() => {
+    cy.login();
+    cy.visit('/dashboard');
+    cy.deleteAllReports();
+    cy.deleteAllContacts();
+  });
+
+  before('', () => {
+    //Step 1: Log in, navigate to the contacts page and create individual, organization, and committee contacts
+    cy.login();
+    cy.visit('/dashboard');
+    cy.url().should('contain', '/dashboard');
+    cy.get('.p-menubar').find('.p-menuitem-link').contains('Reports').click();
+    cy.medWait();
+
+    //Step 2: Create a report and navigate to the transactions page
+    const report = generateReportObject();
+    cy.createReport(report);
+  });
+
+  it('Tests contact creation', () => {
+    cy.login();
+    cy.visit('/dashboard');
+    cy.get('.p-menubar').find('.p-menuitem-link').contains('Reports').click();
+    cy.medWait();
+    cy.navigateToTransactionManagement();
+    cy.medWait();
+    cy.createTransactionSchA(tTreeIndividualA, contactIndividual);
+    cy.medWait();
+    cy.createTransactionSchA(tTreeOrganizationA, contactOrganization);
+    cy.medWait();
+    cy.createTransactionSchA(tTreeJFTransA, contactCommittee);
+    cy.medWait();
+
+    cy.get('.p-menubar').find('.p-menuitem-link').contains('Contacts').click();
+    cy.medWait();
+    cy.contains('td', contactIndividual['name']).should('exist');
+    cy.contains('td', contactOrganization['name']).should('exist');
+    cy.contains('td', contactCommittee['name']).should('exist');
+  });
+});