Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAC_RECOUNT_RECEIPT #671

Merged
merged 6 commits into from
Nov 4, 2022
Merged

PAC_RECOUNT_RECEIPT #671

merged 6 commits into from
Nov 4, 2022

Conversation

toddlees
Copy link
Contributor

@toddlees toddlees commented Nov 4, 2022 •
edited
Loading

#530

Refactors memo_code constant logic

@toddlees toddlees changed the title PAC_RECOUNT_RECEIPT [WIP] PAC_RECOUNT_RECEIPT Nov 4, 2022
mjtravers
mjtravers reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling the memo_code refactor, it looks great.

All is good except I can't figure out how we know the back_reference_sched_name is 'SA17'. How is that value figured out?

front-end/src/app/shared/models/transaction-types/PAC_RECOUNT_RECEIPT.model.ts Outdated Show resolved Hide resolved
@mjtravers mjtravers changed the title [WIP] PAC_RECOUNT_RECEIPT PAC_RECOUNT_RECEIPT Nov 4, 2022
mjtravers
mjtravers approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@mjtravers mjtravers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections made. Passes CR.

@mjtravers mjtravers merged commit 330d0c6 into develop Nov 4, 2022
@mjtravers mjtravers deleted the feature/530-pac-recount-receipt branch November 4, 2022 20:37
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
7.7% 7.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjtravers mjtravers mjtravers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddlees @mjtravers