-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/463 national party recount legal proceedings #698
Merged
mjtravers
merged 10 commits into
develop
from
feature/463-National-Party-Recount-Legal-Proceedings
Nov 18, 2022
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd5c72f
Updates validator commit hash
Elaine-Krauss-TCG 5f1bcc7
Updates validator commit hash again
Elaine-Krauss-TCG 5ef5f91
Adds the JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT transaction
Elaine-Krauss-TCG 8131db9
Updates validator hash again
Elaine-Krauss-TCG 85c6947
Adds in the labels for the new transaction's sub transactions so that…
Elaine-Krauss-TCG efd5537
Updates unit test for new transaction
Elaine-Krauss-TCG 48cc7fa
cypress/support/transaction_nav_trees.spec.ts
Elaine-Krauss-TCG 64301b3
Updates a couple elements in the cypress transaction nav tree details…
Elaine-Krauss-TCG f87fd77
Updates the list of sub-transactions to correct an error
Elaine-Krauss-TCG 5d360d6
Update validate hash
mjtravers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
.../shared/models/transaction-types/JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT.model.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { SchATransaction, ScheduleATransactionTypes } from '../scha-transaction.model'; | ||
import { JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT } from './JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT.model'; | ||
|
||
describe('JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT', () => { | ||
let transactionType: JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT; | ||
|
||
beforeEach(() => { | ||
transactionType = new JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT(); | ||
}); | ||
|
||
it('should create an instance', () => { | ||
expect(transactionType).toBeTruthy(); | ||
expect(transactionType.scheduleId).toBe('A'); | ||
expect(transactionType.componentGroupId).toBe('E'); | ||
}); | ||
|
||
it('#factory() should return a SchATransaction', () => { | ||
const txn: SchATransaction = transactionType.getNewTransaction(); | ||
expect(txn.form_type).toBe('SA17'); | ||
expect(txn.transaction_type_identifier).toBe(ScheduleATransactionTypes.JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT); | ||
}); | ||
|
||
it('#contributionPurposeDescripReadonly() should return constant', () => { | ||
const descrip = transactionType.contributionPurposeDescripReadonly(); | ||
expect(descrip).toBe('Recount/Legal Proceedings Account Transfer of JF Proceeds'); | ||
}); | ||
}); |
51 changes: 51 additions & 0 deletions
51
...c/app/shared/models/transaction-types/JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT.model.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { LabelUtils } from 'app/shared/utils/label.utils'; | ||
import { schema } from 'fecfile-validate/fecfile_validate_js/dist/JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT'; | ||
import { TransactionType } from '../../interfaces/transaction-type.interface'; | ||
import { | ||
AggregationGroups, | ||
SchATransaction, | ||
ScheduleATransactionTypeLabels, | ||
ScheduleATransactionTypes, | ||
} from '../scha-transaction.model'; | ||
import { | ||
CANCEL_CONTROL, | ||
SAVE_ANOTHER_CONTROL, | ||
SAVE_LIST_CONTROL, | ||
TransactionNavigationControls, | ||
} from '../transaction-navigation-controls.model'; | ||
|
||
export class JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT implements TransactionType { | ||
scheduleId = 'A'; | ||
componentGroupId = 'E'; | ||
isDependentChild = false; | ||
title = LabelUtils.get( | ||
ScheduleATransactionTypeLabels, | ||
ScheduleATransactionTypes.JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT | ||
); | ||
schema = schema; | ||
transaction = undefined; | ||
parentTransaction = undefined; | ||
childTransactionType = undefined; | ||
subTransactionTypes = [ | ||
ScheduleATransactionTypes.PAC_NATIONAL_PARTY_RECOUNT_JF_TRANSFER_MEMO, | ||
ScheduleATransactionTypes.INDIVIDUAL_NATIONAL_PARTY_RECOUNT_JF_TRANSFER_MEMO, | ||
ScheduleATransactionTypes.TRIBAL_NATIONAL_PARTY_RECOUNT_JF_TRANSFER_MEMO, | ||
]; | ||
navigationControls?: TransactionNavigationControls = new TransactionNavigationControls( | ||
[], | ||
[CANCEL_CONTROL], | ||
[SAVE_LIST_CONTROL, SAVE_ANOTHER_CONTROL] | ||
); | ||
|
||
contributionPurposeDescripReadonly(): string { | ||
return 'Recount/Legal Proceedings Account Transfer of JF Proceeds'; | ||
} | ||
|
||
getNewTransaction() { | ||
return SchATransaction.fromJSON({ | ||
form_type: 'SA17', | ||
transaction_type_identifier: ScheduleATransactionTypes.JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT, | ||
aggregation_group: AggregationGroups.NPARTY_RECOUNT_ACCOUNT, | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transaction names that are used throughout this file are associated with the transaction accordion on the front-end. Those entries are sometimes different from their Unique Transaction Identifiers.