Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/463 correct transfer name #772

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Patch/463 correct transfer name #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd676c
correct name of jf transfer recount
toddlees Nov 29, 2022
5fa53f4
update labels of national party recount account types to avoid confusion
toddlees Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion front-end/cypress/support/transaction_nav_trees.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type SchATransactionName =
| 'Earmark Receipt'
| 'Business/Labor Organization Receipt - Non-Contribution Account'
| 'Individual Receipt - Non-Contribution Account'
| 'Joint Fundraising Transfer - National Party Recount Account'
| 'Joint Fundraising Transfer - National Party Recount/Legal Proceedings Account'
| 'Joint Fundraising Transfer - National Party Pres. Nominating Convention Account';

export type ChildTransactionName =
Expand Down
22 changes: 17 additions & 5 deletions front-end/src/app/shared/models/scha-transaction.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export const ScheduleATransactionTypeLabels: LabelList = [
[ScheduleATransactionTypes.IN_KIND_TRANSFER_FEA, 'In-Kind Transfer - Federal Election Activity'],
[
ScheduleATransactionTypes.JF_TRANSFER_NATIONAL_PARTY_RECOUNT_ACCOUNT,
'Joint Fundraising Transfer - National Party Recount Account',
'Joint Fundraising Transfer - National Party Recount/Legal Proceedings Account',
],
[
ScheduleATransactionTypes.JF_TRANSFER_NATIONAL_PARTY_CONVENTION_ACCOUNT,
Expand Down Expand Up @@ -262,10 +262,22 @@ export const ScheduleATransactionTypeLabels: LabelList = [
[ScheduleATransactionTypes.PARTY_RECOUNT_RECEIPT, 'Party Recount Receipt'],
[ScheduleATransactionTypes.PAC_RECOUNT_RECEIPT, 'PAC Recount Receipt'],
[ScheduleATransactionTypes.TRIBAL_RECOUNT_RECEIPT, 'Tribal Recount Receipt'],
[ScheduleATransactionTypes.INDIVIDUAL_NATIONAL_PARTY_RECOUNT_ACCOUNT, 'Individual National Party Recount Account'],
[ScheduleATransactionTypes.PARTY_NATIONAL_PARTY_RECOUNT_ACCOUNT, 'Party National Party Recount Account'],
[ScheduleATransactionTypes.PAC_NATIONAL_PARTY_RECOUNT_ACCOUNT, 'PAC National Party Recount Account'],
[ScheduleATransactionTypes.TRIBAL_NATIONAL_PARTY_RECOUNT_ACCOUNT, 'Tribal National Party Recount Account'],
[
ScheduleATransactionTypes.INDIVIDUAL_NATIONAL_PARTY_RECOUNT_ACCOUNT,
'Individual National Party Recount/Legal Proceedings Account',
],
[
ScheduleATransactionTypes.PARTY_NATIONAL_PARTY_RECOUNT_ACCOUNT,
'Party National Party Recount/Legal Proceedings Account',
],
[
ScheduleATransactionTypes.PAC_NATIONAL_PARTY_RECOUNT_ACCOUNT,
'PAC National Party Recount/Legal Proceedings Account',
],
[
ScheduleATransactionTypes.TRIBAL_NATIONAL_PARTY_RECOUNT_ACCOUNT,
'Tribal National Party Recount/Legal Proceedings Account',
],
[
ScheduleATransactionTypes.INDIVIDUAL_NATIONAL_PARTY_HEADQUARTERS_BUILDINGS_ACCOUNT,
'Individual National Party Headquarters Buildings Account',
Expand Down