Skip to content

Commit

Permalink
[feenkcom/gtoolkit#4097] don't cache extended classes in an extension…
Browse files Browse the repository at this point in the history
… tag
  • Loading branch information
syrel committed Oct 21, 2024
1 parent f79a2b3 commit 88b2d26
Showing 1 changed file with 8 additions and 20 deletions.
28 changes: 8 additions & 20 deletions src/GToolkit-Coder/GtCoderPackageExtensionTag.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ Class {
#name : #GtCoderPackageExtensionTag,
#superclass : #Object,
#instVars : [
'package',
'classes'
'package'
],
#category : #'GToolkit-Coder-Navigation - Model'
}
Expand All @@ -15,19 +14,14 @@ GtCoderPackageExtensionTag class >> forPackage: aRPackage [

{ #category : #testing }
GtCoderPackageExtensionTag >> = anObject [
^ self class == anObject class
and: [ package = anObject package and: [ classes = anObject classes ] ]
^ self class = anObject class
and: [ package = anObject package ]
]

{ #category : #accessing }
GtCoderPackageExtensionTag >> classes [
<return: #Array>
^ classes
]

{ #category : #accessing }
GtCoderPackageExtensionTag >> classes: anObject [
classes := anObject
^ self package extendedClasses asArray
]

{ #category : #accessing }
Expand All @@ -38,12 +32,12 @@ GtCoderPackageExtensionTag >> gtTagName [
{ #category : #testing }
GtCoderPackageExtensionTag >> hasExtendedClasses [
<return: #Boolean>
^ self classes isNotEmpty
^ self package gtDoesExtendClasses
]

{ #category : #testing }
GtCoderPackageExtensionTag >> hash [
^ package hash bitXor: classes hash
^ package hash
]

{ #category : #testing }
Expand All @@ -61,11 +55,6 @@ GtCoderPackageExtensionTag >> name [
^ 'Extensions'
]

{ #category : #hooks }
GtCoderPackageExtensionTag >> onPackageChange [
self classes: self package extendedClasses asArray
]

{ #category : #accessing }
GtCoderPackageExtensionTag >> package [
<return: #RPackage>
Expand All @@ -74,11 +63,10 @@ GtCoderPackageExtensionTag >> package [

{ #category : #accessing }
GtCoderPackageExtensionTag >> package: aRPackage [
package := aRPackage.
self onPackageChange.
package := aRPackage
]

{ #category : #accessing }
GtCoderPackageExtensionTag >> packageName [
^ self package name.
^ self package name
]

0 comments on commit 88b2d26

Please sign in to comment.