Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a context object in search filters #3570

Closed
chisandrei opened this issue Jan 19, 2024 · 4 comments
Closed

Introduce a context object in search filters #3570

chisandrei opened this issue Jan 19, 2024 · 4 comments
Assignees
@JurajKubelka
Labels
enhancement
Milestone
v1.0

Comments

@chisandrei
Copy link
Member

Search filters should support a context object that can be used to adapt filters and other aspects of the views/tools
chisandrei added a commit to feenkcom/gt4pharo that referenced this issue Jan 23, 2024
@chisandrei
Add a highlighter for literal values [feenkcom/gtoolkit#3570]
d6c72f1
syrel pushed a commit that referenced this issue Jan 23, 2024
Release version v1.0.430
1ac6f81 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.430/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gt4pharo@d6c72f by Andrei Chi�
Add a highlighter for literal values  [#3570]
@JurajKubelka JurajKubelka self-assigned this Oct 11, 2024
@JurajKubelka JurajKubelka added this to the v1.0 milestone Oct 11, 2024
@JurajKubelka
Copy link
Member

Related code: GtSearchFilterContext.

@seandenigris
Copy link
Contributor

seandenigris commented Oct 11, 2024 •
edited
Loading

Is this at all related to the tool contexts referred to in #3422 ?

@chisandrei
Copy link
Member Author

@seandenigris Nope. This is totally something else. Mostly allowing the filter object to know from which context it was created, so we can have filters for the same class, package, etc

@JurajKubelka
Copy link
Member

Implemented as a part of #3983.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajKubelka JurajKubelka

Labels
enhancement
Projects
GT
Status: Done
Milestone
v1.0
Development

No branches or pull requests
3 participants
@seandenigris @JurajKubelka @chisandrei