Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is a bad idea to write CR terminated lines to a git README.md #4036

Closed
svenvc opened this issue Sep 26, 2024 · 0 comments
Closed

It is a bad idea to write CR terminated lines to a git README.md #4036

svenvc opened this issue Sep 26, 2024 · 0 comments
Assignees

Comments

@svenvc
Copy link
Contributor

svenvc commented Sep 26, 2024

We have a couple of places where we add to or edit the README.md in a git repository.

It is a bad idea to write CR terminated lines there, we can use ZnNewLineWriterStream to do an automatic platform specific conversion.

  • GtGitPackageAndBaselineCreationForm>>#addInstallationInstructions
  • GtGitDatabaseCreationForm>>#addToReadme
  • GtGitRepository>>#gtReadmeFor:context:

This often results in mixed line endings now, which is REALLY BAD idea.

@svenvc svenvc self-assigned this Sep 26, 2024
@svenvc svenvc closed this as completed Sep 26, 2024
syrel pushed a commit that referenced this issue Sep 26, 2024
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.1154/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gtoolkit-coder@73666e by Juraj Kubelka
Merge f97edb7688387738de6872ad4e01012ae7ac4ce9


feenkcom/gtoolkit-coder@6b40f8 by Juraj Kubelka
add filters widget [#3983]

It is possible to add and remove filters.


j-brant/SmaCC@c3c5d4 by John Brant
fix node creation signal bug created by previous optimization

feenkcom/gt4pharo@df5b72 by Juraj Kubelka
Merge ac0531938d5bba2df28252be1b3e09aaa09346f7


feenkcom/gt4pharo@91a1a7 by Juraj Kubelka
add new filter descriptors [#3983]


feenkcom/gtoolkit-inspector@4efa9b by Tudor Girba
Merge b33e57c010df357e98c675189d2eb60053529110


feenkcom/gtoolkit-inspector@e0d793 by Tudor Girba
simplify the string view


feenkcom/gt4git@212f27 by Sven Van Caekenberghe
Use ZnNewLineWriterStream when writing to README.md in git [#4036]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant