Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Iceberg to CLI in the GT release image and in the development image #4041

Open
girba opened this issue Sep 27, 2024 · 1 comment
Open

Switch Iceberg to CLI in the GT release image and in the development image #4041

girba opened this issue Sep 27, 2024 · 1 comment
Labels
enhancement
Milestone
v1.0

Comments

@girba
Copy link
Member

girba commented Sep 27, 2024

No description provided.

@girba girba added this to the v1.0 milestone Sep 27, 2024
@svenvc
Copy link
Contributor

svenvc commented Sep 27, 2024

Apart from the risk of doing something new, which we should take IMHO, there are two main issues:

  • (1) it would require git cli to be present where you want to use GT for git, but we could have a fallback/switchback to the old implementation if we detect git is missing
  • (2) the current build will probably still use the old implementation as well, even though we now have a separate iceberg-git-cli repository meant to be loaded first, but this is untested

svenvc added a commit to feenkcom/iceberg-git-cli that referenced this issue Oct 25, 2024
@svenvc
Make GtIceRepositorySwitcher class>>#switchAll use some IceGitCliPlat…
eec6703 
…form validations before switching [feenkcom/gtoolkit#4041]
syrel pushed a commit that referenced this issue Oct 25, 2024
Release version v1.0.1246
0bfff34 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.1246/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gt4magritte@a35c5e by Aliaksei Syrel
[#4124] spawn a magritte definition on alt+click on a label

feenkcom/iceberg-git-cli@eec670 by Sven Van Caekenberghe
Make GtIceRepositorySwitcher class>>#switchAll use some IceGitCliPlatform validations before switching [#4041]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@girba @svenvc