Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate github search to null safety #2149

Merged
merged 1 commit into from
Feb 14, 2021
Merged

migrate github search to null safety #2149

merged 1 commit into from
Feb 14, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Feb 14, 2021 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Migrate two examples to null safety.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Abhishek01039
Copy link
Contributor Author

I have tested this app on android and ios.
So there is a changed in some of the generated files.

@felangel felangel added example Example application refactor Refactor an existing implementation labels Feb 14, 2021
felangel
felangel approved these changes Feb 14, 2021
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 💯 🚀

@felangel felangel merged commit e5741c4 into felangel:null_safety Feb 14, 2021
@Abhishek01039 Abhishek01039 deleted the flutter_github_search_safety branch February 17, 2021 12:17
felangel pushed a commit that referenced this pull request Mar 3, 2021
@Abhishek01039 @felangel
refactor(github_search): migrate to null-safety (#2149)
228d039
felangel pushed a commit that referenced this pull request Mar 4, 2021
@Abhishek01039 @felangel
refactor(github_search): migrate to null-safety (#2149)
13587ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@Abhishek01039 Abhishek01039

Labels
example Example application refactor Refactor an existing implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhishek01039 @felangel