Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract Attribute Using Wrong Source #70

Closed
JonasBirk opened this issue Aug 12, 2024 · 2 comments · Fixed by #71
Closed

Contract Attribute Using Wrong Source #70

JonasBirk opened this issue Aug 12, 2024 · 2 comments · Fixed by #71
Assignees

Comments

@JonasBirk
Copy link

Hey there,

First off, I just want to say thanks for creating and maintaining this API—it’s been incredibly useful!

I noticed on the /clubs/281/players endpoint that the "contract" attribute might be pulling the same value as "market value" instead of the contract expiry date (e.g., Stefan Ortega should have "Jun 30, 2026"). We’d be interested in this field, so I wanted to flag it just in case this isn't intentional.

{
"id": "281",
"players": [
{
"id": "85941",
"name": "Stefan Ortega",
"position": "Goalkeeper",
"dateOfBirth": "Nov 6, 1992",
"age": "31",
"nationality": [
"Germany",
"Spain"
],
"height": "1,85m",
"foot": "right",
"signedFrom": "Arminia Bielefeld",
"contract": "€9.00m",
"marketValue": "€9.00m"

}

Thanks again for this great work!

@felipeall
Copy link
Owner

Hello @JonasBirk, thanks for the heads up! I will work on this and deploy a fix

@felipeall
Copy link
Owner

felipeall commented Aug 14, 2024

@JonasBirk please note that the "contracts" field is only available for the current season. It means that calls to previous seasons like /clubs/281/players?season_id=2022 won't include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants