Get player full name from profile header

[felipeall]

Close #61

Summary by CodeRabbit

• New Features
  • Enhanced player profile retrieval to include full names with spaces.
• Refactor
  • Improved XPath query for more accurate name extraction in player profiles.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing the retrieval and presentation of player names in the profile service. Two primary changes were made: the introduction of a join_str parameter in the get_player_profile method to better format the "name" attribute, and an adjustment to the XPath expression in the JerseyNumbers class to refine the selection criteria for player names.

Changes

File Path	Change Summary
.../players/profile.py	Added join_str parameter to get_player_profile for better name formatting.
.../utils/xpath.py	Modified NAME XPath expression to refine name selection criteria.

Assessment against linked issues

Objective	Addressed	Explanation
Player names on the /profile endpoint (#61)	❓	It is unclear if the changes fully address the requirement for a "fullname" property since the modifications seem to focus on improving the existing name retrieval rather than adding a new property.

The changes made seem to improve the handling of player names, but it is not explicitly clear if they introduce a new "fullname" property as requested in the issue. Further review or clarification might be necessary to confirm complete compliance with the issue's requirements.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6cc2e4e and 6bffd4b.

Files selected for processing (2)

• app/services/players/profile.py (1 hunks)
• app/utils/xpath.py (1 hunks)

Additional comments not posted (2)

app/services/players/profile.py (1)

42-42: The addition of join_str=" " to concatenate parts of the player's name is a good implementation to ensure the full name is constructed correctly.

Please ensure that other parts of the system that rely on the "name" attribute are updated to handle this change appropriately.

app/utils/xpath.py (1)

21-21: Refinement of the XPath expression to avoid unwanted elements like spans is a precise improvement for accurately extracting the player's name.

Please verify the accuracy of this XPath expression in different scenarios to ensure it consistently selects the correct elements.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.