Fix write-after-close and other bugs #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Close the streams via `destroy()` rather than manually closing the
underlying file descriptors. This avoids a Node.js SIGABRT crash
caused by an EBADF error from writing to a closed file descriptor.
* Track the number of in-flight writes so that the `drain` event is
not emitted unless the writes are actually drained.
* Wait until drained before closing the streams.
* Rather than building a string with an O(N^2) algorithm and an
arbitrary 1000 character limit, use `writable.cork()` and
`writable.uncork()` to let Node.js efficiently batch writes.
* Use a Map to efficiently implement the write queue. Maps iterate
in insertion order so there is no behavior change.
Maps iterate in insertion order so there is no behavior change.
|
@rhansen 👋 I'm not actively maintaining this repo anymore, but your changes seem nice, so I added you as a contributor. I'll leave it to you to merge this PR as-is or wait to see if you can get a review from somebody. If you want I'm also happy to give you access to the npm package so you can publish new releases. |
|
@rhansen I added you to npm, you should be able to publish new package versions now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple commits (please do not squash) to fix a few bugs and improve code health.
Bugs fixed:
db.rm()with an unknown key deleted an unrelated entry.