Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find module fetch #257

Closed
Uysim opened this issue Nov 28, 2018 · 10 comments
Closed

Could not find module fetch #257

Uysim opened this issue Nov 28, 2018 · 10 comments

Comments

@Uysim
Copy link

Uysim commented Nov 28, 2018

It happen when I upgrade ember-cli to lastest verions

Could not find module `fetch` imported from `ember-simple-auth-token/authenticators/

Packages

ember-cli: 3.5.1
ember-cli-fastboot: 2.0.0
ember-simple-auth-token: 4.0.5
@fenichelar
Copy link
Owner

I see you are using fastboot, have you added node-fetch to your fastbootDependencies as described here?

@Uysim
Copy link
Author

Uysim commented Nov 29, 2018

@fenichelar Yes I did

@Uysim
Copy link
Author

Uysim commented Nov 29, 2018

I also try to import fetch from 'fetch' in my application model. It is fine

@fenichelar
Copy link
Owner

fenichelar commented Nov 29, 2018

Can you provide an example application that demonstrates the issue? I'm not able to reproduce it.

@Uysim
Copy link
Author

Uysim commented Nov 30, 2018

I try to reproduce it at https://github.com/Uysim/reproduce-fetch-module

@fenichelar
Copy link
Owner

@Uysim Thank you. I am able to reproduce the issue with that repo. However, I haven't been able to figure out the problem... @jpadilla Thoughts?

@Uysim
Copy link
Author

Uysim commented Dec 3, 2018

I don't know whether it is relate to this https://github.com/ember-cli/ember-fetch#use-with-fastboot

@gregorymark
Copy link

gregorymark commented Dec 11, 2018

Looks like it's related to
ember-cli/ember-fetch#62
and
mainmatter/ember-simple-auth#1138

And going from the end of that second issue, install ember-fetch separately just using
ember install ember-fetch seems to make it work nicely.

@Uysim
Copy link
Author

Uysim commented Jan 10, 2019

@gregorymark Yes I fixed it by to ember install ember-fetch. Thank you

@Uysim
Copy link
Author

Uysim commented Jan 10, 2019

``

@Uysim Uysim closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants