Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember fetch version, fixes #255 #256

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

joshuataylor
Copy link
Contributor

@joshuataylor joshuataylor commented Nov 16, 2018

The ember-fetch dependency just needs to be bumped to also allow v6.

Testing:
In your package.json, change ember-simple-auth-token to be:

    "ember-simple-auth-token": "joshuataylor/ember-simple-auth-token#bump-ember-fetch",

Now rerun yarn, and you should be good to test.

@Uysim
Copy link

Uysim commented Nov 28, 2018

When this gonna merge?

@jpadilla
Copy link
Contributor

@Uysim does this fix your issue on #257 as well?

@Uysim
Copy link

Uysim commented Nov 29, 2018

I tested it. It didn't fixed my problem

Copy link
Owner

@fenichelar fenichelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update package-lock.json as well.

@fenichelar fenichelar merged commit 872b5e7 into fenichelar:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants