expose dowloadFromInfo and drop some dependencies #1
Conversation
|
I always thought that the download function returning a stream was a much easier to use and understand API. What are your reasons for preferring the callback version? I agree with getting rid of removing EventVat. |
|
I don't really care either way - stream vs callback. This just seemed like an easier way to implement |
andrewrk
changed the title
|
OK I updated the pull request. Now it does not break backwards compatibility but it still removes 2 dependencies and exposes |
| var request = require('request'); | ||
| var _ = require('underscore'); | ||
| var getInfo = require('./info'); | ||
| var crequest = require('./crequest'); | ||
| var util = require('./util'); | ||
|
|
||
| module.exports = ytdl; | ||
| ytdl.getInfo = getInfo; | ||
| ytdl.downloadFromInfo = downloadFromInfo; |
|
@fent I made |
| stream.resolve(req); | ||
| var format = util.chooseFormat(info.formats, options); | ||
| if (format instanceof Error) { | ||
| // give user a chance to attach 'error' handler |
|
Looks good. Awesome. Thank you for putting up with the back and forth, and contributing. 👍 |
expose dowloadFromInfo and drop some dependencies
|
And thank you for having an open mind to these changes :) |
expose dowloadFromInfo and drop some dependencies
* chore(package): update miniget to version 4.2.2 * drop node v10 & update package-lock.json * update workflow versions * try #1 to fix unit tests Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: TimeForANinja <[email protected]>
This pull request:
getInfofollowed bydownloadFromInfo.PassThroughstream instead.All tests pass.