Update webview.js to fix issue with popup-message notifications (https://github.com/ferdium/ferdium-app/issues/1675) #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix to merge this fix into official receipe for msteams: https://gist.github.com/tulexx/54df51101366b329cbdcc050f9a9037c discussed in issue ferdium/ferdium-app#1675
vraravam
requested changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Bugfix to remove annoying alert-message notifications in msteams addon, which duplicate the push-notifications and have to been closed each on its own by user.
Thanks to @tulexx for his patch.
MR to merge this fix into official receipe for msteams: https://gist.github.com/tulexx/54df51101366b329cbdcc050f9a9037c
discussed in issue ferdium/ferdium-app#1675