ensure deterministic component iteration order #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed due to changes I made to `TriggerAppEngine::new` to support components. I used a `HashMap` without realizing the iteration order of triggers (and their configs) matters. Fixes fermyon#1469 Signed-off-by: Joel Dice <[email protected]>
|
Note that I considered writing a test for this, but the non-determinism makes it tricky. I'd prefer to avoid tests which sometimes pass and sometimes fail, and I'm not sure how to avoid that here. |
itowlson
approved these changes
May 10, 2023
|
Re testing, it could be done probabilistically - use a manifest with (say) 5 components in it, check the print order matches the manifest order, repeat 20 times, and that should get it to a "GUID collision/cosmic ray bitflip" risk of being wrong. But given the very small impact of ordering issues, I'm not sure it's worth it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed due to changes I made to
TriggerAppEngine::newto support components. I used aHashMapwithout realizing the iteration order of triggers (and their configs) matters.Fixes #1469