fix(cmd/up): --help takes precedence over --build #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't build applications when the user is requesting help. Signed-off-by: Danielle Lancashire <[email protected]>
fibonacci1729
approved these changes
Mar 5, 2024
karthik2804
approved these changes
Mar 5, 2024
itowlson
reviewed
Mar 5, 2024
There was a problem hiding this comment.
As UpCommand has an explicit help field, have we considered annotating that with suitable "not at the same time as" attributes? That might make it clearer to the user that --build --help is not a valid combination, rather than silently dropping the --build bit...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't build applications when the user is requesting help.
I also did a quick local test to make sure a missing component binary doesn't print any new errors/cause issues when
--helping - and that the re-ordering is safe (spin up --buildstill works) although i assume our integration tests already somewhat cover that path.fixes #2323