Fix build when RUSTFLAGS is set for native builds #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
fix-rustflags-for-native
branch
from
5a74070
to
a85ab9a
Compare
lann
approved these changes
Mar 15, 2024
This fixes an issue where if `RUSTFLAGS` were set then the wasm cross-compiles performed would accidentally inherit the same flags. For me locally I was configuring a different native linker which didn't support wasm, so the wasm build failed due to the custom linker being used erroneously. Signed-off-by: Alex Crichton <[email protected]>
alexcrichton
force-pushed
the
fix-rustflags-for-native
branch
from
3387595
to
e11b82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if
RUSTFLAGSwere set then the wasm cross-compiles performed would accidentally inherit the same flags. For me locally I was configuring a different native linker which didn't support wasm, so the wasm build failed due to the custom linker being used erroneously.