Option to suppress plugin on-run compatibility warnings #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
fibonacci1729
approved these changes
Apr 4, 2024
vdice
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Any thoughts on discoverability of this env var for users?
Too heavyweight to pair with a new flag eg --suppress-plugin-compatibility-warnings? If that was in place, clap would also show the env var value, right?
Or maybe just a docs mention?
Or just keep it as-is on a need-to-know basis only? 🤫
|
I considered mirroring it to a flag but who is ever going to type out the flag? This is really for "I live on Spin prereleases/canaries and I know it" people - it's completely irrelevant for stable. But yeah maybe discoverability and/or programmatic use justify it. Still would feel weird to see it on stable. I dunno. |
|
👍 Let's get this in as-is and we can always increase awareness if requested. |
vdice
approved these changes
Apr 4, 2024
kate-goldenring
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put it in your profile and never think about it again.
Until someone reports a weird bug with malformed JSON that you just can't reproduce on your local machine. Then think about it a lot. (Yes, this would have bitten me nastily with the launch metadata work for multi-trigger, and that's why I remain in two minds about it.)