Granular route matching #2464
Merged
Granular route matching #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
fancy-schmancy-routes-2
branch
5 times, most recently
from
6f6128a
to
c118079
Compare
lann
reviewed
Apr 29, 2024
crates/trigger-http/src/lib.rs
Outdated
| client_addr: SocketAddr, | ||
| ) -> Result<Vec<(&'a [&'a str], String)>> { | ||
| ) -> Result<Vec<([Cow<'static, str>; 2], String)>> { | ||
| const fn cowed(strs: &[&'static str; 2]) -> [Cow<'static, str>; 2] { |
There was a problem hiding this comment.
FRIGHTEN THE VARIABLES INTO COMPLIANCE WITH YOUR TYPES
crates/trigger-http/src/lib.rs
Outdated
| client_addr: SocketAddr, | ||
| ) -> Result<Vec<(&'a [&'a str], String)>> { | ||
| ) -> Result<Vec<([Cow<'static, str>; 2], String)>> { |
There was a problem hiding this comment.
I would return Strings here. Avoiding allocations is nice and all but all these headers get rewritten a couple of times downstream anyway; probably not worth the extra complexity here.
itowlson
force-pushed
the
fancy-schmancy-routes-2
branch
from
c118079
to
f53b927
Compare
fibonacci1729
approved these changes
Apr 29, 2024
itowlson
force-pushed
the
fancy-schmancy-routes-2
branch
from
f53b927
to
8002b28
Compare
lann
approved these changes
Apr 29, 2024
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
fancy-schmancy-routes-2
branch
from
8002b28
to
bd9e735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1923.
This is WIP, pushed for squigglies if I break the integration tests. It's not yet ready for review.This uses
routefindersyntax, except we still allow/...for the trailing wildcard. E.g./users/:userid/notes/....The trailing wildcard goes in the
spin-path-infoheader, as it does today. Named segment wildcards go in headers along the lines ofspin-path-match-<name>e.g.spin-path-match-userid. Feel free to suggest better ideas: I kind of did the first thing I thought of because I knew you reprobates would bikeshed it anyway. grinI am not 100% comfortable with the test coverage, but am not sure what else I can meaningfully add. I'd welcome feedback or suggestions!
Thanks again to @lann and @fibonacci1729 for getting me off an unproductive design and onto this one!