Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a docker compose file that creates an o11y stack for Spin to use #2465

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

calebschoepp
Copy link
Collaborator

@calebschoepp calebschoepp commented Apr 22, 2024

This is still a WIP, but I'd love feedback on the config itself and on where we want to store this config.

@rylev
Copy link
Collaborator

rylev commented Apr 23, 2024

Can you give me some more context on how you imagine these being used? My gut is that this should be in a different repo, but without knowing about how this will be used, it's hard to say.

@calebschoepp
Copy link
Collaborator Author

Can you give me some more context on how you imagine these being used? My gut is that this should be in a different repo, but without knowing about how this will be used, it's hard to say.

I envision some using this to easily setup an observability stack for their spin app

cd o11y
docker compose up
# Now do my Spin things

We could potentially put this in another repo, or hide it behind a spin plugin, or somewhere else. But, I do think we need to provide a simple and coherent story for how users of Spin can get the very wide set of o11y tools running easily.

@itowlson
Copy link
Contributor

Is this solving a Spin-specific observability issue or a "generic observability tools setup" issue? That might help guide the discussion.

@lann
Copy link
Collaborator

lann commented Apr 24, 2024

I don't have a strong opinion about what repo this should live in, but if it's going to be in this repo I would like to put it in e.g. contrib/o11y-stack (or hack/..., as the k8s ecosystem seems to like) to indicate that it isn't an actively-supported feature of Spin itself.

As an aside I think tools/modsurfer should be moved for the same reason.

@calebschoepp
Copy link
Collaborator Author

I like the pattern of hack/o11y-stack/*.

@calebschoepp
Copy link
Collaborator Author

Is this solving a Spin-specific observability issue or a "generic observability tools setup" issue? That might help guide the discussion.

Good framing question @itowlson. There is nothing inherently specific to Spin here so I would say this is a "generic observability tools setup" issue.

@calebschoepp
Copy link
Collaborator Author

I've moved it to hack/o11y-stack/. Looking for another round of reviews on if we're okay storing it there.

Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The great thing about hack/* is that we can just delete it later 🙂

@calebschoepp calebschoepp merged commit 33afee8 into fermyon:main Apr 25, 2024
17 checks passed
@calebschoepp calebschoepp deleted the o11y-stack branch April 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants