-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a docker compose file that creates an o11y stack for Spin to use #2465
Conversation
Can you give me some more context on how you imagine these being used? My gut is that this should be in a different repo, but without knowing about how this will be used, it's hard to say. |
I envision some using this to easily setup an observability stack for their spin app cd o11y
docker compose up
# Now do my Spin things We could potentially put this in another repo, or hide it behind a spin plugin, or somewhere else. But, I do think we need to provide a simple and coherent story for how users of Spin can get the very wide set of o11y tools running easily. |
Is this solving a Spin-specific observability issue or a "generic observability tools setup" issue? That might help guide the discussion. |
I don't have a strong opinion about what repo this should live in, but if it's going to be in this repo I would like to put it in e.g. As an aside I think |
I like the pattern of |
Good framing question @itowlson. There is nothing inherently specific to Spin here so I would say this is a "generic observability tools setup" issue. |
Signed-off-by: Caleb Schoepp <[email protected]>
91417b9
to
9f79852
Compare
I've moved it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The great thing about hack/*
is that we can just delete it later 🙂
This is still a WIP, butI'd love feedback on the config itself and on where we want to store this config.