added local_addr() to listeners to display random port numbers #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splayed properly in the terminal Signed-off-by: Garik Asplund <[email protected]>
Signed-off-by: Lann Martin <[email protected]>
|
Thanks! I just pushed an update to dedupe a bunch of stuff I noticed while reviewing. lgtm! |
lann
approved these changes
Apr 25, 2024
|
I guess since I made a significant change here too I'd better get a neutral 3rd party to review as well 🙂 |
fibonacci1729
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had to move some logging info out of run and into serve and serve_tls functions since the thread is blocking. An alternative would be to spawn a new thread but this seemed to work and is the most straightforward approach.
I feel like it'd be good to add tests but I'm not exactly sure the best way to go about that. If anyone has guidance there or feedback for potential issues with this modification please let me know.
Closes #2471