fix StoreBuilder::inherit_limited_network
#2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
force-pushed
the
fix-inherit-limited-network
branch
from
3896596
to
672e048
Compare
rylev
approved these changes
Jun 4, 2024
rylev
approved these changes
Jun 5, 2024
|
@dicej looks like this got stuck for some reason. I'm not sure, but a rebase might fix things? |
|
The DCO app got borked for a while. It is now healthy but it seems like you have to re-push to get it to regenerate status. |
Previously, this called `WasiCtxBuilder::inherit_network`, but that had no effect since `StoreBuilder::build_with_data` later overwrites that setting by calling `WasiCtxBuilder::socket_addr_check` with a lambda that uses `StoreBuilder::net_pool` to check addresses. In this cases, `StoreBuilder::net_pool` has not had any subnets added to it, so it denies everything, which is the opposite of what we intended. The solution is to have `StoreBuilder::inherit_limited_network` update `net_pool` to allow all IPv4 and IPv6 networks. Signed-off-by: Joel Dice <[email protected]> address review feedback - Rename `StoreBuilder::inherit_limited_network` to `inherit_network` - Add comments explaining use of `Pool` and CIDR addresses Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
fix-inherit-limited-network
branch
from
e7dcb42
to
f08c69b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this called
WasiCtxBuilder::inherit_network, but that had no effect sinceStoreBuilder::build_with_datalater overwrites that setting by callingWasiCtxBuilder::socket_addr_checkwith a lambda that usesStoreBuilder::net_poolto check addresses. In this case,StoreBuilder::net_poolhas not had any subnets added to it, so it denies everything, which is the opposite of what we intended.The solution is to have
StoreBuilder::inherit_limited_networkupdatenet_poolto allow all IPv4 and IPv6 networks.