Improve OTel error logging #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Jun 18, 2024
lann
reviewed
Jun 18, 2024
lann
reviewed
Jun 18, 2024
lann
reviewed
Jun 18, 2024
calebschoepp
force-pushed
the
improve-otel-errors
branch
from
54cdd47
to
9c482d3
Compare
lann
reviewed
Jun 18, 2024
lann
reviewed
Jun 18, 2024
Probably just okay. If it is something other than a channel full error it will likely show up as the first error. And at the very least we'll always be tracking it at trace. |
lann
approved these changes
Jun 19, 2024
Signed-off-by: Caleb Schoepp <[email protected]>
calebschoepp
force-pushed
the
improve-otel-errors
branch
from
9c482d3
to
f6d6549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2565
Opted to rate limit all errors and not just channel full errors.