Improve non-interactive behaviour of spin new
#2643
Conversation
Signed-off-by: itowlson <[email protected]>
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn can_generate_over_existing_files_if_so_configured() { |
There was a problem hiding this comment.
nit: there's a lot of set up for these tests that is indentical. Would it make sense to test both scenarios in the same test perhaps by doing the "cookies" test, then deleting the spin.toml, and trying again?
There was a problem hiding this comment.
Yes, there's a lot of shared test setup across the template tests. I'd prefer to keep the individual tests specific, but as a later pass we should refactor the entire test suite to reduce duplication/copy-paste and make the "what is specific about this setup and about the expected results" pop a lot more. So I am going to punt on this for now but I do totally accept your point!
| /// If the output directory already contains files, generate the new files into | ||
| /// it without confirming, overwriting any existing files with the same names. | ||
| #[clap( | ||
| long = "allow-overwrite", |
There was a problem hiding this comment.
I'm not 100% sold on the name as it can somewhat beg the question of what we are allowing the overwrite of, but I can't think of a better alternative so I'm fine with it as is.
An alternative approach to the problem identified in #2627. With this PR:
spin newandspin addwill:-value,--values-file, or--accept-defaultsinteraction::Silentstrategy, which already gets exercised via the unit testsspin newandspin addnow support a--allow-overwriteflag which will allow generating into a non-empty directory. In a terminal, this skips the prompt; in a non-terminal, it changes the behaviour.The
--allow-overwriteflag has a--allow-overwritesalias because I kept typing the latter when testing despite having defined the singular form not two minutes before that is why.The PR has unit tests for the non-interactive case; obviously it's not very practical to includes tests for the interactive case but it seemed to work when I tried it!