Retry running conformance tests as part of runtime tests #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
|
I think we should maybe require explicitly opting out of docker tests (via e.g. ugly env var) rather than detecting whether docker is installed. |
|
I don't have a strong opinion here. What are your reasons for this? Allowing people to filter out docker based tests locally even when they have docker installed? |
Just "don't make it too easy to skip tests accidentally" |
rylev
force-pushed
the
conformance-test-try-again
branch
from
5fc7419
to
383a10c
Compare
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
conformance-test-try-again
branch
from
383a10c
to
190f313
Compare
lann
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back #2663
This time we skip tests that require Docker when docker is not installed.
The first commit is equivalent to #2663 so the only new code is in the subsequent commit.