[Factors] Key-Value in Trigger2 #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
key-value-trigger2
branch
from
335851e
to
3c26407
Compare
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
key-value-trigger2
branch
from
3c26407
to
e42b249
Compare
Merged
lann
approved these changes
Aug 15, 2024
Comment on lines
+93
to
+127
| const DEFAULT_SPIN_STORE_FILENAME: &str = "sqlite_key_value.db"; | ||
|
|
||
| /// The key-value runtime configuration resolver used by the trigger. | ||
| /// | ||
| /// Takes a base path for the local store. | ||
| pub fn key_value_resolver(local_store_base_path: PathBuf) -> key_value::RuntimeConfigResolver { | ||
| let mut key_value = key_value::RuntimeConfigResolver::new(); | ||
|
|
||
| // Register the supported store types. | ||
| // Unwraps are safe because the store types are known to not overlap. | ||
| key_value | ||
| .register_store_type(spin_factor_key_value_spin::SpinKeyValueStore::new( | ||
| local_store_base_path, | ||
| )) | ||
| .unwrap(); | ||
| key_value | ||
| .register_store_type(spin_factor_key_value_redis::RedisKeyValueStore::new()) | ||
| .unwrap(); | ||
| key_value | ||
| .register_store_type(spin_factor_key_value_azure::AzureKeyValueStore::new()) | ||
| .unwrap(); | ||
|
|
||
| // Add handling of "default" store. | ||
| key_value.add_default_store( | ||
| "default", | ||
| key_value::StoreConfig { | ||
| type_: spin_factor_key_value_spin::SpinKeyValueStore::RUNTIME_CONFIG_TYPE.to_owned(), | ||
| config: toml::toml! { | ||
| path = DEFAULT_SPIN_STORE_FILENAME | ||
| }, | ||
| }, | ||
| ); | ||
|
|
||
| key_value | ||
| } |
There was a problem hiding this comment.
Of course it doesn't need to be done in this PR but we'll almost certainly break this out into an e.g. key_value module with the next factor added, yeah?
| let mut key_value = key_value::RuntimeConfigResolver::new(); | ||
|
|
||
| // Register the supported store types. | ||
| // Unwraps are safe because the store types are known to not overlap. |
There was a problem hiding this comment.
micro-nit: avoid the "s" word...
Suggested change
| // Unwraps are safe because the store types are known to not overlap. | |
| // Unwraps are fine because the store types are known to not overlap. |
There was a problem hiding this comment.
👍 I'll change this in the next PR to avoid having to run CI again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2711 so marking as draft until that merges
This moves runtime config handling for Spin CLI to its own crate.