Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SafeBuffer's prototype inherit from Buffer #23

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Make SafeBuffer's prototype inherit from Buffer #23

merged 1 commit into from
Jul 5, 2019

Conversation

vkarpov15
Copy link
Contributor

Re: Automattic/mongoose#7102, you get annoying issues if you use SafeBuffer's prototype, like:

const Buffer = require('safe-buffer').Buffer;
Buffer.prototype.copy; // undefined on Node.js 4.2

This fixes that

vkarpov15 added a commit to Automattic/mongoose that referenced this pull request Oct 21, 2018
@vkarpov15
fix(types): use core Node.js buffer prototype instead of safe-buffer …
5a6e295 
…because safe-buffer is broken for Node.js 4.x

Fix #7102
Re: feross/safe-buffer#23
@vkarpov15 vkarpov15 mentioned this pull request Oct 26, 2018
Closed
vkarpov15 added a commit to Automattic/mongoose that referenced this pull request Nov 5, 2018
@vkarpov15
refactor(buffer): add a more robust workaround for feross/safe-buffer#23
d3cfdcb 


Fix #6826
This was referenced Nov 6, 2018
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
@vkarpov15 vkarpov15 mentioned this pull request Dec 13, 2018
Closed
@feross feross merged commit a43206b into feross:master Jul 5, 2019
@feross
Copy link
Owner

feross commented Jul 5, 2019

Thanks for the PR, this is released as 5.2.0.

@feross feross mentioned this pull request Aug 7, 2019
Merged
@hasezoey hasezoey mentioned this pull request Jul 3, 2020
Closed
@legobeat legobeat mentioned this pull request May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarpov15 @feross