AEA-684 p2p_stub connection refactoring and tests #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-83
to
-85
| if not target_file.is_file(): | ||
| target_file.touch() | ||
| logger.warn("file {} doesn't exist, creating it ...".format(target_file)) |
There was a problem hiding this comment.
file created on open(, "ab") if it can not be created at this point touch will fail as well, check is_file quite useless, cause if it's non file object it will fail on open
| envelope = make_test_envelope(to_="con2") | ||
| await self.connection1.send(envelope) | ||
|
|
||
| await asyncio.wait_for(self.connection2.receive(), timeout=5) |
There was a problem hiding this comment.
Add some assertions on envelope content?
DavidMinarsch
approved these changes
Jun 30, 2020
DavidMinarsch
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1435 +/- ##
===========================================
- Coverage 91.37% 88.46% -2.92%
===========================================
Files 217 217
Lines 15251 15254 +3
===========================================
- Hits 13936 13494 -442
- Misses 1315 1760 +445
Continue to review full report at Codecov.
|
solarw
force-pushed
the
feature/p2p_stub_connection
branch
from
d35c515
to
ca8a8d3
Compare
solarw
force-pushed
the
feature/p2p_stub_connection
branch
from
c94f210
to
279aea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
small async improvements and tests
Fixes
Types of changes
Checklist
developbranch (left side). Also you should start your branch off ourdevelop.aea clitool works