AEA-608 Minor changes to dialogue API #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es except initial one; formatting;
5A11
changed the title
…feature/dialogue
… protocols and updated skills with AgentRole -> Role change; Black now applies to _pb2.py files;
| @@ -68,11 +68,11 @@ class TacDialogue(Dialogue): | |||
| ), | |||
| } | |||
|
|
|||
| class AgentRole(Dialogue.Role): | |||
| class Role(Dialogue.Role): | |||
There was a problem hiding this comment.
The roles are not auto sorted by alphabet as you can see below
There was a problem hiding this comment.
Please amend generator to do so
5A11
commented
Jul 3, 2020
| # Run protocol buffer compiler | ||
| try_run_protoc( | ||
| self.path_to_generated_protocol_package, self.protocol_specification.name | ||
| ) | ||
|
|
||
| # Run black formatting | ||
| try_run_black_formatting(self.path_to_generated_protocol_package) | ||
|
|
There was a problem hiding this comment.
Running black after protoc so it formats _pb2.py files too.
DavidMinarsch
approved these changes
Jul 3, 2020
DavidMinarsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor PR with the following changes:
AgentRole-->Rolein FipaDialogue.counterpartyfield is automatically set for all messages except the initial one. This can be done for the initial message once a newcreate_dialoguemethod is added which gets thecounterpartyas a field.Due to the changed names (item 1 and 2 above), skill codes no longer work and linters fail. Those were not changed because skills are being heavily changed in another branch.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.aea clitool works