Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/erc1155 #1466

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Feature/erc1155 #1466

merged 4 commits into from
Jul 6, 2020

Conversation

DavidMinarsch
Copy link
Contributor

@DavidMinarsch DavidMinarsch commented Jul 5, 2020

Proposed changes

Adapt erc1155 skill to new architecture; extend contract api protocol; docs fixes; add additional pylint options

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2020

Codecov Report

Merging #1466 into develop will decrease coverage by 0.15%.
The diff coverage is 59.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1466      +/-   ##
===========================================
- Coverage    89.73%   89.57%   -0.16%     
===========================================
  Files          242      242              
  Lines        17100    17183      +83     
===========================================
+ Hits         15344    15391      +47     
- Misses        1756     1792      +36     
Flag Coverage Δ
#unittests 89.57% <59.55%> (-0.16%) ⬇️
Impacted Files Coverage Δ
aea/skills/base.py 97.03% <ø> (ø)
...ckages/fetchai/protocols/contract_api/dialogues.py 92.85% <ø> (ø)
...es/fetchai/protocols/contract_api/serialization.py 8.28% <2.85%> (-1.31%) ⬇️
.../fetchai/connections/ledger/contract_dispatcher.py 85.71% <83.33%> (-0.59%) ⬇️
aea/cli/generate_wealth.py 100.00% <100.00%> (ø)
aea/configurations/base.py 96.00% <100.00%> (ø)
aea/crypto/registries/base.py 100.00% <100.00%> (ø)
...fetchai/protocols/contract_api/contract_api_pb2.py 100.00% <100.00%> (ø)
...ges/fetchai/protocols/contract_api/custom_types.py 80.64% <100.00%> (+1.33%) ⬆️
packages/fetchai/protocols/contract_api/message.py 87.34% <100.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261bd50...ec272cd. Read the comment docs.

@DavidMinarsch DavidMinarsch merged commit 6abad1e into develop Jul 6, 2020
@DavidMinarsch DavidMinarsch deleted the feature/erc1155 branch July 6, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants