Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docs #1472

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Feature/docs #1472

merged 2 commits into from
Jul 6, 2020

Conversation

DavidMinarsch
Copy link
Contributor

Proposed changes

Quick fix to versions in docs; adds soef docs update; disables unreliable ci tests;

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@DavidMinarsch DavidMinarsch changed the base branch from master to develop July 6, 2020 11:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #1472 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1472   +/-   ##
========================================
  Coverage    89.53%   89.53%           
========================================
  Files          242      242           
  Lines        17183    17183           
========================================
  Hits         15385    15385           
  Misses        1798     1798           
Flag Coverage Δ
#unittests 89.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8aef35...3355d74. Read the comment docs.

@DavidMinarsch DavidMinarsch merged commit f4262c4 into develop Jul 6, 2020
@DavidMinarsch DavidMinarsch deleted the feature/docs branch July 6, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants