fix deploy and check scripts; enable disabled tests #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1474 +/- ##
===========================================
- Coverage 89.57% 89.53% -0.04%
===========================================
Files 242 242
Lines 17183 17183
===========================================
- Hits 15391 15385 -6
- Misses 1792 1798 +6
Continue to review full report at Codecov.
|
| @@ -40,6 +40,8 @@ | |||
| DEFAULT_CONFIG_FILE_PATHS = [ | |||
| Path("aea", "connections", "stub", "connection.yaml"), | |||
| Path("aea", "protocols", "default", "protocol.yaml"), | |||
| Path("aea", "protocols", "signing", "protocol.yaml"), | |||
| Path("aea", "protocols", "state_update", "protocol.yaml"), | |||
| Path("aea", "skills", "error", "skill.yaml"), | |||
There was a problem hiding this comment.
what about ledger connection and ledger_api/contract_api protocols?
There was a problem hiding this comment.
maybe in a separate PR
There was a problem hiding this comment.
they are not in the aea package so not relevant.
panasevychol
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR applies a few minor fixes which are possible post-release.
Fixes
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.aea clitool worksFurther comments