[AEA-685] Gym connection fully async and full test coverage #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self._queues = {} # type: Dict[str, asyncio.Queue] | ||
| self._queue: Optional[asyncio.Queue] = None | ||
| self._threaded_pool: ThreadPoolExecutor = ThreadPoolExecutor(10) |
There was a problem hiding this comment.
Any reason for a high default of 10? Should also be declared as constant on top or be made configurable.
Comment on lines
145
to
146
| if self._queue is None: # pragma: nocover | ||
| raise ValueError("Channel is not connected") |
There was a problem hiding this comment.
If you wrap self._queue in a property you can reduce some duplication of code..
DavidMinarsch
suggested changes
Jul 7, 2020
solarw
force-pushed
the
feature/gym_async_and_tests
branch
5 times, most recently
from
9203bac
to
571f789
Compare
solarw
changed the title
solarw
force-pushed
the
feature/gym_async_and_tests
branch
from
571f789
to
d8a35e2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1479 +/- ##
===========================================
- Coverage 89.57% 88.14% -1.43%
===========================================
Files 242 242
Lines 17183 17188 +5
===========================================
- Hits 15391 15150 -241
- Misses 1792 2038 +246
Continue to review full report at Codecov.
|
| @@ -8,7 +8,7 @@ aea_version: '>=0.5.0, <0.6.0' | |||
| fingerprint: {} | |||
| fingerprint_ignore_patterns: [] | |||
| connections: | |||
| - fetchai/gym:0.3.0 | |||
| - fetchai/gym:0.4.0 | |||
There was a problem hiding this comment.
You also need to bump the gym aea as a result
solarw
force-pushed
the
feature/gym_async_and_tests
branch
from
4f02dc9
to
79601d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
improvements and better tests coverage for gym connection
Fixes
#1468
Types of changes
Checklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.aea clitool works