Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new gui design AEA-674 #1487

Merged
merged 7 commits into from
Jul 14, 2020
Merged

Conversation

panasevychol
Copy link
Contributor

@panasevychol panasevychol commented Jul 10, 2020

Proposed changes

New design of GUI applied #1395

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@panasevychol panasevychol added gui issues related to GUI components cli Issues related to the CLI tool `aea` labels Jul 10, 2020
@panasevychol panasevychol self-assigned this Jul 10, 2020
@panasevychol panasevychol marked this pull request as ready for review July 14, 2020 15:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #1487 into develop will increase coverage by 1.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1487      +/-   ##
===========================================
+ Coverage    88.41%   90.32%   +1.90%     
===========================================
  Files          242      243       +1     
  Lines        17184    17209      +25     
===========================================
+ Hits         15194    15544     +350     
+ Misses        1990     1665     -325     
Flag Coverage Δ
#unittests 90.32% <ø> (+1.90%) ⬆️
Impacted Files Coverage Δ
aea/cli_gui/__init__.py 100.00% <ø> (ø)
aea/helpers/dialogue/base.py 85.03% <0.00%> (-6.40%) ⬇️
aea/protocols/generator/base.py 82.33% <0.00%> (-0.39%) ⬇️
aea/test_tools/test_cases.py 84.87% <0.00%> (-0.36%) ⬇️
packages/fetchai/connections/soef/connection.py 100.00% <0.00%> (ø)
...kages/fetchai/connections/oef/object_translator.py 100.00% <0.00%> (ø)
aea/mail/base.py 100.00% <0.00%> (+1.78%) ⬆️
packages/fetchai/connections/oef/connection.py 65.25% <0.00%> (+2.46%) ⬆️
packages/fetchai/protocols/ledger_api/dialogues.py 85.18% <0.00%> (+3.70%) ⬆️
...etchai/connections/p2p_libp2p_client/connection.py 93.70% <0.00%> (+10.01%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b800f...a57dfc4. Read the comment docs.

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit 69f5933 into develop Jul 14, 2020
@DavidMinarsch DavidMinarsch deleted the feature/new-gui-design branch July 15, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues related to the CLI tool `aea` gui issues related to GUI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants