Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEA-699 connections test coverage #1488

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

solarw
Copy link
Contributor

@solarw solarw commented Jul 13, 2020

Proposed changes

better connections coverage

Fixes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #1488 into develop will increase coverage by 1.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1488      +/-   ##
===========================================
+ Coverage    88.76%   90.05%   +1.28%     
===========================================
  Files          243      243              
  Lines        17178    17157      -21     
===========================================
+ Hits         15248    15450     +202     
+ Misses        1930     1707     -223     
Flag Coverage Δ
#unittests 90.05% <100.00%> (+1.28%) ⬆️
Impacted Files Coverage Δ
packages/fetchai/connections/ledger/connection.py 69.56% <ø> (+37.13%) ⬆️
.../fetchai/connections/ledger/contract_dispatcher.py 51.31% <ø> (+16.79%) ⬆️
...es/fetchai/connections/ledger/ledger_dispatcher.py 67.44% <ø> (+38.71%) ⬆️
packages/fetchai/connections/ledger/base.py 71.18% <100.00%> (+18.64%) ⬆️
aea/test_tools/test_cases.py 85.22% <0.00%> (-1.71%) ⬇️
packages/fetchai/protocols/ledger_api/dialogues.py 85.18% <0.00%> (+3.70%) ⬆️
...ckages/fetchai/protocols/contract_api/dialogues.py 92.85% <0.00%> (+10.71%) ⬆️
...ges/fetchai/protocols/contract_api/custom_types.py 77.41% <0.00%> (+12.90%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605f33d...bbcca99. Read the comment docs.

@solarw solarw force-pushed the feature/connections-coverage branch from 664ac56 to bbcca99 Compare July 13, 2020 09:41
@DavidMinarsch
Copy link
Contributor

LGTM, please fix failing static tests

@DavidMinarsch DavidMinarsch changed the title connections test coverage AEA-699 connections test coverage Jul 13, 2020
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit 5a86614 into develop Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants