Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint #1490

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

lrahmani
Copy link
Collaborator

Proposed changes

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #1490 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1490      +/-   ##
===========================================
- Coverage    88.76%   88.74%   -0.02%     
===========================================
  Files          243      243              
  Lines        17178    17178              
===========================================
- Hits         15248    15245       -3     
- Misses        1930     1933       +3     
Flag Coverage Δ
#unittests 88.74% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
aea/test_tools/test_cases.py 85.22% <0.00%> (-1.71%) ⬇️
aea/mail/base.py 100.00% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605f33d...82eea87. Read the comment docs.

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit ddb614b into develop Jul 13, 2020
@lrahmani lrahmani deleted the hotfix/golangci-lint-unknown-argument branch July 14, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants