Increase libp2ps connections code coverage to 100% #1497
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1497 +/- ##
===========================================
+ Coverage 89.92% 90.27% +0.34%
===========================================
Files 243 243
Lines 17239 17209 -30
===========================================
+ Hits 15503 15536 +33
+ Misses 1736 1673 -63
Continue to review full report at Codecov.
|
| assert self._in_queue is not None, "Input queue not initialized." | ||
| self._in_queue.put_nowait(data) | ||
| if data is None: |
There was a problem hiding this comment.
Not sure why this was moved here; data is already used in line 706
There was a problem hiding this comment.
Now you might be putting None on the queue
There was a problem hiding this comment.
yes, exactly.
The _receive_from_node task will exit and the multiplexer will receive None on its scheduled receive
| which = shutil.which("go") | ||
| if which is None: | ||
| raise Exception("Libp2p Go should me installed") |
There was a problem hiding this comment.
why has this been removed?
There was a problem hiding this comment.
because connection already does the check (using _check_go_installed())
…overage Increase libp2ps connections code coverage to 100%
Proposed changes
Fixes #1468, #1162