Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing file for libp2p improve coverage #1499

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

lrahmani
Copy link
Collaborator

No description provided.

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #1499 into develop will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1499      +/-   ##
===========================================
+ Coverage    90.28%   90.39%   +0.10%     
===========================================
  Files          243      244       +1     
  Lines        17209    17277      +68     
===========================================
+ Hits         15538    15617      +79     
+ Misses        1671     1660      -11     
Flag Coverage Δ
#unittests 90.39% <ø> (+0.10%) ⬆️
Impacted Files Coverage Δ
aea/skills/base.py 96.47% <0.00%> (-0.57%) ⬇️
aea/components/base.py 100.00% <0.00%> (ø)
packages/fetchai/connections/gym/connection.py 100.00% <0.00%> (ø)
packages/fetchai/connections/tcp/tcp_client.py 100.00% <0.00%> (ø)
packages/fetchai/connections/webhook/connection.py 100.00% <0.00%> (ø)
...ackages/fetchai/connections/p2p_stub/connection.py 100.00% <0.00%> (ø)
...kages/fetchai/connections/p2p_client/connection.py 100.00% <0.00%> (ø)
...ages/fetchai/connections/http_client/connection.py 100.00% <0.00%> (ø)
...ages/fetchai/connections/http_server/connection.py 100.00% <0.00%> (ø)
aea/helpers/logging.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b7ecf...244a866. Read the comment docs.

@DavidMinarsch DavidMinarsch merged commit 8dae395 into develop Jul 15, 2020
@DavidMinarsch DavidMinarsch deleted the feature/libp2p-improve-coverage branch July 15, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants