Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update api docs #1500

Merged
merged 1 commit into from
Jul 15, 2020
Merged

update api docs #1500

merged 1 commit into from
Jul 15, 2020

Conversation

DavidMinarsch
Copy link
Contributor

Proposed changes

Fixes the api docs

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #1500 into develop will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1500      +/-   ##
===========================================
- Coverage    90.39%   90.34%   -0.05%     
===========================================
  Files          244      244              
  Lines        17277    17277              
===========================================
- Hits         15617    15609       -8     
- Misses        1660     1668       +8     
Flag Coverage Δ
#unittests 90.34% <100.00%> (-0.05%) ⬇️
Impacted Files Coverage Δ
packages/fetchai/connections/soef/connection.py 100.00% <100.00%> (ø)
aea/launcher.py 93.13% <0.00%> (-4.91%) ⬇️
...kages/fetchai/connections/p2p_libp2p/connection.py 99.07% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dae395...7538466. Read the comment docs.

@DavidMinarsch DavidMinarsch merged commit ef7177c into develop Jul 15, 2020
@DavidMinarsch DavidMinarsch deleted the feature/docs branch July 15, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants