Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% on ledger_apis module #373

Merged
merged 4 commits into from
Nov 5, 2019
Merged

100% on ledger_apis module #373

merged 4 commits into from
Nov 5, 2019

Conversation

Totoual
Copy link
Contributor

@Totoual Totoual commented Nov 4, 2019

Fixes

100% coverage on aea/cryptos/ledger_api module.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

marcofavorito
marcofavorito suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I suggested to do some changes, but happy to discuss them.

@marcofavorito marcofavorito self-requested a review November 5, 2019 11:07
marcofavorito
marcofavorito approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Totoual Totoual merged commit f910951 into develop Nov 5, 2019
@DavidMinarsch DavidMinarsch deleted the tests/test_ledger_apis branch November 6, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch left review comments

@marcofavorito marcofavorito marcofavorito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Totoual @marcofavorito @DavidMinarsch