Draft of programming an AEA, proof read overall #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMinarsch
suggested changes
Nov 5, 2019
docs/hacking-an-agent.md
Outdated
| public_key_1 = "mailbox1" | ||
| mailbox1 = MailBox(OEFLocalConnection(public_key_1, node)) | ||
| private_key_pem_path = os.path.join(CUR_PATH, "data", "priv.pem") | ||
| wallet = Wallet({'default': private_key_pem_path}) |
There was a problem hiding this comment.
The wallet creation should be done first.
Then they can get the public key like so:
public_key = wallet.public_keys['default']
Then they can set up a mailbox like so:
mailbox = MailBox(stub_connection)
There was a problem hiding this comment.
The stub connection doesn't use the public key.
There was a problem hiding this comment.
True, I would still swap it around as in all but this connection case the public key is needed and derived from the wallet.
docs/hacking-an-agent.md
Outdated
| private_key_pem_path = os.path.join(CUR_PATH, "data", "priv.pem") | ||
| wallet = Wallet({'default': private_key_pem_path}) | ||
| ``` | ||
|
|
||
| Using a variable for accessing running ledgers, initialise the agent. | ||
| Get the public key from the wallet. You would use this to talk to an OEF or Fetch.ai ledger node. |
There was a problem hiding this comment.
I would comment this out. We might use it another time but here it does not add value.
There was a problem hiding this comment.
I put the pk comments in a Note. Awaiting your approval.
merge with develop
Bumps oef sdk to 0.8.1 and adds reconnection procedure
merge with develop.
…o feature/gui_tests merged from latest.
Add test in aea
Feature/docs
Feature/gui tests
Update clone path
Add is connected status to skill context
Feature/car park conn
Change default wallet to FETCHAI
DavidMinarsch
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Including a DRAFT page of instructions to fix: #298.
Complete proof read of everything from last week.
Fixes
None.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.aea clitool worksFurther comments
None.